Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions Updates - yaml & json validation #3501

Merged
merged 6 commits into from
Mar 27, 2023
Merged

Actions Updates - yaml & json validation #3501

merged 6 commits into from
Mar 27, 2023

Conversation

GrantBirki
Copy link
Contributor

@GrantBirki GrantBirki commented Mar 26, 2023

Actions Updates

This pull request does the following:

  • Updates actions/setup-go and actions/setup-python to v4 tags
  • Adds a new Actions workflow to validate json and yaml files in the repository

Why?

I recently developed a new GitHub Action to validate json and yaml files. It runs in under 5 seconds for this repository and it is a native JS Action. I noticed that @Raffo (who I work with at @github) contributes to this repository in my feed so I took a look at this repo. I saw there were a handful of *.yaml files in this repo and figured it would be helpful if they got validated on pull requests through GitHub actions so maintainers can know if they are valid or not before merging. Hopefully this helps! ❤️

While I was making commits, I also upgraded some Actions tag versions as well

Checklist

  • Unit tests updated
  • End user documentation updated

Note: neither options in the checklist apply

@k8s-ci-robot
Copy link
Contributor

Welcome @GrantBirki!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 26, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 26, 2023
@stmcginnis
Copy link

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 26, 2023
@Raffo
Copy link
Contributor

Raffo commented Mar 27, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GrantBirki, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2905a26 into kubernetes-sigs:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants