Actions Updates - json/yaml validation

[GrantBirki]

Actions Updates - json/yaml validation

This pull request adds a new Actions workflow to validate all JSON / YAML files in the repository to ensure they are valid.

This workflow will run on pull requests to ensure that all files are valid from new contributors so that they do not introduce issues if they are missed in a review.

Related: kubernetes-sigs/external-dns#3501

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: GrantBirki
Once this PR has been reviewed and has the lgtm label, please assign bentheelder for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @GrantBirki!

It looks like this is your first PR to kubernetes-sigs/kind 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kind has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @GrantBirki. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[BenTheElder]

Hmm we have relatively few of these and a LOT of CI jobs already. Currently linting runs in pull-kind-verify and can be replicated locally (make verify).

We use actions to run CI with VMs more easily but generally we use Kubernetes' CI which has some properties like ensuring the latest commits are tested before merge and giving contributors a command to rerun tests.

[BenTheElder]

So we're granting write permission to an external repo at a tag ...?

pretty sure we already turned off write permissions for all actions at the repo level

[GrantBirki]

We can remove that pull-requests: write line and disable the Action's ability to "comment" back on PRs to lock things down a bit more. Can optionally pin the commit sha rather than using a tag as well.

I also did not notice the make verify command and if that is sufficient, then perhaps this PR is not needed. Just let me know and I can either leave it open or close it out 👍

[BenTheElder]

Thanks! I think we'll stick with verify.