Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to specify endpoint for AWS Provider #3662

Conversation

piotrkpc
Copy link

@piotrkpc piotrkpc commented Jun 6, 2023

Description

This PR adds a configuration option to the AWS provider to specify Endpoint for AWS Route53 client used in AWS Provider. It will help write more comprehensive e2e tests with tools such as Localstack or external stubs of Route53 API.
It does not change API or add configuration options exposed to the user.

Add Endpoint configuration option for AWSConfig used by AWS Provider.

Checklist

  • Unit tests updated - N/A
  • End user documentation updated - N/A

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 6, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 6, 2023
@szuecs
Copy link
Contributor

szuecs commented Jun 8, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 8, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 24, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mloiseleur, piotrkpc
Once this PR has been reviewed and has the lgtm label, please assign szuecs for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2023
@piotrkpc
Copy link
Author

@mloiseleur This is no longer needed as the code was nicely refactored by @johngmyers as part of #3648 in 794a10d

@piotrkpc piotrkpc closed this Jul 28, 2023
@ezraroi
Copy link

ezraroi commented Jan 9, 2024

@piotrkpc How can we control this without code? Looks like the AWS endpoint is not configured from file or ENV var.
Looks like AWS Go SDK V2 is supporting this, while V1 which is used does not
https://docs.aws.amazon.com/sdkref/latest/guide/feature-ss-endpoints.html#ss-endpoints-sdk-compat

@piotrkpc
Copy link
Author

piotrkpc commented Jan 9, 2024

@ezraroi not sure, I've not been following the code lately but the latest version should work. AWS GO SDK v1 also can take endpoint from env variables. https://docs.aws.amazon.com/sdkref/latest/guide/feature-endpoint-discovery.html

@ezraroi
Copy link

ezraroi commented Jan 9, 2024

@piotrkpc Thanks but i am not sure it is possible to override the Route53 address this way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants