-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to specify endpoint for AWS Provider #3662
add option to specify endpoint for AWS Provider #3662
Conversation
/ok-to-test |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mloiseleur, piotrkpc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mloiseleur This is no longer needed as the code was nicely refactored by @johngmyers as part of #3648 in 794a10d |
@piotrkpc How can we control this without code? Looks like the AWS endpoint is not configured from file or ENV var. |
@ezraroi not sure, I've not been following the code lately but the latest version should work. AWS GO SDK v1 also can take endpoint from env variables. https://docs.aws.amazon.com/sdkref/latest/guide/feature-endpoint-discovery.html |
@piotrkpc Thanks but i am not sure it is possible to override the Route53 address this way |
Description
This PR adds a configuration option to the AWS provider to specify Endpoint for AWS Route53 client used in AWS Provider. It will help write more comprehensive e2e tests with tools such as Localstack or external stubs of Route53 API.
It does not change API or add configuration options exposed to the user.
Add
Endpoint
configuration option forAWSConfig
used by AWS Provider.Checklist