Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DynamoDB registry implementation #3648

Merged
merged 7 commits into from
Jun 23, 2023

Conversation

johngmyers
Copy link
Contributor

@johngmyers johngmyers commented Jun 1, 2023

Description

Adds a new registry implementation which uses AWS DynamoDB.

This mitigates the TXT registry's aggravation of rate limits on the underlying zone. It is a much more elegant solution to privacy issues than encrypting the TXT registry's records. It is also a more appropriate storage mechanism for the type of data.

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 1, 2023
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 1, 2023
@johngmyers johngmyers force-pushed the dynamodb branch 2 times, most recently from d37a60a to 1fea64d Compare June 1, 2023 05:04
@johngmyers johngmyers force-pushed the dynamodb branch 2 times, most recently from f5af42f to 4006327 Compare June 4, 2023 21:36
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 4, 2023
@johngmyers johngmyers force-pushed the dynamodb branch 3 times, most recently from faf49d2 to 7e1a319 Compare June 5, 2023 01:44
@johngmyers johngmyers changed the title WIP Add DynamoDB registry implementation Add DynamoDB registry implementation Jun 13, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 13, 2023
@johngmyers
Copy link
Contributor Author

The failing check appears to be an infrastructure problem with Coveralls, not a problem with the PR's code.

Copy link
Contributor

@szuecs szuecs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm I added some nits to fix

main.go Show resolved Hide resolved
provider/aws/session.go Outdated Show resolved Hide resolved
registry/dynamodb.go Outdated Show resolved Hide resolved
registry/dynamodb.go Outdated Show resolved Hide resolved
registry/dynamodb.go Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit ae0c06e into kubernetes-sigs:master Jun 23, 2023
9 checks passed
@johngmyers johngmyers deleted the dynamodb branch June 24, 2023 02:50
@johngmyers johngmyers mentioned this pull request Sep 13, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants