Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add johngmyers as approver #3931

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

johngmyers
Copy link
Contributor

Description

Add @johngmyers as an approver

Requirements:

[x] Reviewer of the codebase for at least 3 months

[x] Primary reviewer for at least 10 substantial PRs to the codebase

#3285, #3174, #3201, #3104, #3589,
#3590, #3297, #2553 #3295, #3263,
#3738, #3451, #3745, #3695, #3690,
#3724

[x] Reviewed or merged at least 30 PRs to the codebase

#3285, #3174, #2157, #3261, #3201,
#3297, #2461, #3546, #3589, #3588,
#3590, #3607, #3600, #3603, #3590,
#3295, #3263, #3222, #2054, #2553,
#3104, #3263, #3640, #3660, #3652,
#3674, #3635, #3648, #3729, #3738,
#3736, #3451, #3745, #3690, #3724,
#3711, #3758, #3702, #3726, #3863,
#3835

[ ] Nominated by a subproject owner
[ ] With no objections from other subproject owners
[x] Done through PR to update the top-level OWNERS file

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 13, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 13, 2023
@Raffo
Copy link
Contributor

Raffo commented Sep 14, 2023

Thank you for all your work. The project wouldn't be how it is today without you joining to help.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8e03ec0 into kubernetes-sigs:master Sep 14, 2023
15 checks passed
@johngmyers johngmyers deleted the jgmyers branch September 14, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants