-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple hostnames in internal annotation for pods #3603
Allow multiple hostnames in internal annotation for pods #3603
Conversation
|
Welcome @Pluggi! |
dns-controller does indeed support that syntax. Thanks for doing this. /lgtm |
/ok-to-test |
Please fix:
|
It's all green now :) |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Pluggi, szuecs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR allows multiple record names separated by commas in the internal-hostname annotation of pods, as is available for services.
Checklist