Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add johngmyers to reviewers #3664

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

johngmyers
Copy link
Contributor

Description

Per the requirements in https://github.com/kubernetes/community/blob/master/community-membership.md :

[x] member for at least 3 months
[x] Primary reviewer for at least 5 PRs to the codebase

#3285, #3174, #3201, #3104, #3589,
#3590, #3295, #3263, #3297, #2553

[x] Reviewed or merged at least 20 substantial PRs to the codebase

#3285, #3174, #2157, #3261, #3201,
#3297, #2461, #3546, #3589, #3588,
#3590, #3607, #3600, #3603, #3590,
#3295, #3263, #3263, #3640, #3222,
#2054, #2553, #3104,

[x] Knowledgeable about the codebase
[ ] Sponsored by a subproject approver
[ ] With no objections from other approvers
[x] Done through PR to update the OWNERS file
[x] May either self-nominate, be nominated by an approver in this subproject, or be nominated by a robot

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 7, 2023
@szuecs
Copy link
Contributor

szuecs commented Jun 13, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2023
@Raffo
Copy link
Contributor

Raffo commented Jun 13, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9416892 into kubernetes-sigs:master Jun 13, 2023
10 checks passed
@johngmyers johngmyers deleted the reviewer branch June 13, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants