Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support AAAA records from headless services #3600

Merged
merged 2 commits into from
May 19, 2023
Merged

Support AAAA records from headless services #3600

merged 2 commits into from
May 19, 2023

Conversation

johngmyers
Copy link
Contributor

Description

Extends IPv6 support to include headless Services

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 10, 2023
@szuecs
Copy link
Contributor

szuecs commented May 11, 2023 •
edited

/approve
/ok-to-test

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2023
@johngmyers
Copy link
Contributor Author

@szuecs what is needed to get lgtm?

@szuecs
Copy link
Contributor

szuecs commented May 18, 2023

@johngmyers you need to be part of the GitHub org.

@szuecs
Copy link
Contributor

szuecs commented May 18, 2023

Can you try to comment with /lgtm?

@johngmyers
Copy link
Contributor Author

johngmyers commented May 18, 2023 •
edited

I am a Kubernetes Member. One can't lgtm one's own PRs.
/lgtm

@k8s-ci-robot
Copy link
Contributor

@johngmyers: you cannot LGTM your own PR.

In response to this:

I am a Kubernetes Member. One can't lgtm one's on PRs.
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@szuecs
Copy link
Contributor

szuecs commented May 19, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit fd501dd into kubernetes-sigs:master May 19, 2023
@johngmyers johngmyers deleted the ipv6-headless branch May 20, 2023 05:47
@johngmyers johngmyers mentioned this pull request Jun 7, 2023
Merged
2 tasks
@johngmyers johngmyers mentioned this pull request Sep 13, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner Awaiting requested review from njuettner

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees

@szuecs szuecs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johngmyers @szuecs @k8s-ci-robot