Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify planner's data structure #3546

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Simplify planner's data structure #3546

merged 1 commit into from
Apr 14, 2023

Conversation

johngmyers
Copy link
Contributor

Description

Simplifies the data structure used by the planner.

/kind cleanup

Checklist

  • Unit tests updated N/A
  • End user documentation updated N/A

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 14, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 14, 2023
@johngmyers johngmyers force-pushed the plan-refactor branch 2 times, most recently from 2ed40f1 to 4c3ef2e Compare April 14, 2023 02:26
@johngmyers johngmyers changed the title Simplifly planner's data structure Simplify planner's data structure Apr 14, 2023
@szuecs
Copy link
Contributor

szuecs commented Apr 14, 2023

@johngmyers it reads so much better, thanks!

@szuecs
Copy link
Contributor

szuecs commented Apr 14, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 14, 2023
@szuecs
Copy link
Contributor

szuecs commented Apr 14, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit eaabf71 into kubernetes-sigs:master Apr 14, 2023
@johngmyers johngmyers deleted the plan-refactor branch April 14, 2023 16:42
@johngmyers johngmyers mentioned this pull request Jun 7, 2023
Merged
2 tasks
@wbh1 wbh1 mentioned this pull request Sep 1, 2023
Closed
2 tasks
@johngmyers johngmyers mentioned this pull request Sep 13, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner Awaiting requested review from njuettner

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees

@szuecs szuecs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johngmyers @szuecs @k8s-ci-robot