IPv6 internal node IPs are usable externally #3588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
szuecs
reviewed
May 8, 2023
|
/ok-to-test One question other than that I would approve. Thanks for your work @johngmyers |
k8s-ci-robot
added
the
ok-to-test
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, szuecs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Jun 20, 2024
|
@johngmyers @szuecs since this patch is merged, all v6 addresses internal and external are added to the dns entry for e.g. a Kubernetes node or NodePort. Can you maybe revisit this topic again to make it possible to differentiate between internal and external. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IPv6 clusters do not a NATed private-use network; IPv6 node addresses are allocated from the global unicast address space and are accessible from the internet if firewalls allow. IPv6 node addresses are always reported as type
NodeInternalIPdespite being usable both internally and externally.This PR causes the sources that use node IP addresses to treat
NodeInternalIPaddresses that parse as IPv6 as being both internal and external.It also fixes the node, pod, and dns-controller sources to set the record type to
AAAAfor node addresses that have IPv6 syntax.This roughly corresponds to kubernetes/kops#12608.
Fixes #1875
Checklist