Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Azure tutorials #3201

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Improve Azure tutorials #3201

merged 1 commit into from
Jan 17, 2023

Conversation

zioproto
Copy link
Contributor

Improves the Azure Tutorials

  • Bump container images to v0.13.1
  • Add example with kubernetes service and external-dns.alpha.kubernetes.io/hostname annotation
  • Add example with external-dns.alpha.kubernetes.io/internal-hostname
  • Add example used in combination with service.beta.kubernetes.io/azure-load-balancer-internal

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 29, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 24, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 3, 2023
johngmyers
johngmyers suggested changes Jan 3, 2023
View reviewed changes
docs/tutorials/azure-private-dns.md Outdated Show resolved Hide resolved
docs/tutorials/azure-private-dns.md Outdated
./nginx-ingress-controller --publish-service=default/nginx-ingress-controller
```

## Expose an nginx service with an ingress (Optional)

Create a service file called 'nginx.yaml' with the following contents:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this redundant with the Deployment deployed above? I'd think this would get cut down to just deploying the Ingress resource.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The service resource is also different here because ClusterIP is enough, but in the previous snippet the service is of type LoadBalancer.

I am proposing now a new version to avoid duplication of yaml code. Please take a look again.

njuettner
njuettner requested changes Jan 4, 2023
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zioproto for improving our docs, much appreciated ❤️.

When you have time could you try to address the comments from @johngmyers.
If everything is good I'd love to merge your PR.

@zioproto zioproto force-pushed the azure-tutorials branch 4 times, most recently from 7e9f195 to 2ef00e3 Compare January 4, 2023 09:04
@zioproto
Improve Azure tutorials
617a32a 
* Bump container images to v0.13.1
* Add example with kubernetes service and `external-dns.alpha.kubernetes.io/hostname` annotation
* Add example with `external-dns.alpha.kubernetes.io/internal-hostname`
* Add example used in combination with `service.beta.kubernetes.io/azure-load-balancer-internal`
@zioproto
Copy link
Contributor Author

zioproto commented Jan 4, 2023

@johngmyers please take a look again. I pushed new commits that address your comments. Thanks

@johngmyers
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2023
@johngmyers
Copy link
Contributor

/assign @njuettner

@zioproto
Copy link
Contributor Author

@njuettner friendly ping. Can we merge ? thanks

njuettner
njuettner approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner, zioproto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1a556ce into kubernetes-sigs:master Jan 17, 2023
@johngmyers johngmyers mentioned this pull request Jun 7, 2023
Merged
2 tasks
@johngmyers johngmyers mentioned this pull request Sep 13, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers requested changes

@njuettner njuettner njuettner approved these changes

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees

@johngmyers johngmyers

@njuettner njuettner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zioproto @johngmyers @k8s-ci-robot @njuettner