Migrate metadata from TXT to DynamoDB registries #3726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/L
johngmyers
force-pushed
the
dynamodb-migrate
branch
2 times, most recently
from
61b709a
to
96e7fba
Compare
johngmyers
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
szuecs
reviewed
Jun 26, 2023
szuecs
reviewed
Jun 26, 2023
szuecs
reviewed
Jun 26, 2023
|
Small nits other than that lgtm |
|
@szuecs I am awaiting answers to my questions on your review comments. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test pull-external-dns-lint |
johngmyers
force-pushed
the
dynamodb-migrate
branch
from
96e7fba
to
ef8b223
Compare
k8s-ci-robot
removed
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, szuecs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrates the registry metadata from the TXT registry to the DynamoDB registry when the latter is enabled.
One annoyance is that the TXT ownership records don't get deleted unless TXT is added to the set of managed record types. It's not in the default set.
Checklist