New txt registry format #3774

cgroschupp · 2023-07-10T14:01:07Z

Description
Added new txt format metadata

Checklist

Unit tests updated
End user documentation updated

johngmyers · 2023-07-11T15:52:17Z

The code also needs to be able to read the metadata format.

The code does not need to support all possible combinatorics of generating old, new, and metadata. There are only two possible states needed: transition and metadata-only. In transition (default) it should generate metadata format for all records, old format for non-AAAA records, and new format for AAAA records. In metadata-only, it should only generate metadata-format records.

In all cases it should read all three formats. If it reads a format it is configured to not generate, it matches the owner, and it has also read a corresponding metadata-format record, then it should return an Endpoint so the older record gets deleted. See #3726.

registry/txt.go

cgroschupp · 2023-07-19T15:33:02Z

The code also needs to be able to read the metadata format.

@johngmyers I hope I have understood this correctly. I have to think about how to solve it better in extractRecordType.

In transition (default) it should generate metadata format for all records, old format for non-AAAA records, and new format for AAAA records. In metadata-only, it should only generate metadata-format records.

CNAME should also use the new format. This is because it is not possible to create a TXT and CNAME record for the same name.

It may be better to change the type to bool and rename the flag to TXTFormatTransitionEnabled.

johngmyers · 2023-08-29T20:27:02Z

@cgroschupp are you able to rebase?

cgroschupp · 2023-08-30T09:19:05Z

@johngmyers done

johngmyers

We're getting close. Consider taking this out of Draft state.

registry/txt.go

johngmyers · 2023-09-03T03:23:30Z

registry/txt.go

@@ -215,7 +219,7 @@ func (im *TXTRegistry) generateTXTRecord(r *endpoint.Endpoint) []*endpoint.Endpo

 	endpoints := make([]*endpoint.Endpoint, 0)

-	if !im.mapper.recordTypeInAffix() && r.RecordType != endpoint.RecordTypeAAAA {
+	if !im.mapper.recordTypeInAffix() && im.txtFormat == "transition" && r.RecordType != endpoint.RecordTypeAAAA && r.RecordType != endpoint.RecordTypeCNAME {


I'm not sure we should suppress these for type CNAME. I've seen cases where the "new" format wasn't created because the domain got too long. The old format was created because the CNAME was really a Route53 alias record. Perhaps we just need to make this dependent on #3910.

registry/txt_test.go

johngmyers · 2023-09-03T03:46:12Z

registry/txt_test.go

@@ -451,6 +471,7 @@ func testTXTRegistryApplyChanges(t *testing.T) {
 	t.Run("With Templated Suffix", testTXTRegistryApplyChangesWithTemplatedSuffix)
 	t.Run("With Suffix", testTXTRegistryApplyChangesWithSuffix)
 	t.Run("No prefix", testTXTRegistryApplyChangesNoPrefix)
+	t.Run("No prefix Metadata Only", testTXTRegistryApplyChangesNoPrefixMetadataOnly)


Call this just "Metadata only". The results should be the same for with-prefix and with-suffix and the code should test those cases as well.

registry/txt_test.go

k8s-ci-robot · 2023-09-05T11:45:21Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign raffo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

johngmyers · 2023-09-16T02:41:31Z

/hold for #3910

johngmyers · 2023-09-18T19:54:15Z

@cgroschupp please update to account for changes in #3910. RecordTypeA records with an alias ProviderSpecificProperty of true should be encoded in the "new" format as if they had type CNAME. For the "metadata" format they should be encoded as type A.

/hold cancel

k8s-ci-robot · 2023-09-18T19:54:23Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

johngmyers · 2023-09-18T19:58:15Z

/label tide/merge-method-squash

johngmyers · 2023-10-09T00:11:29Z

@cgroschupp are you able to rebase and adjust for changes from #3910?

mloiseleur · 2023-11-07T08:21:54Z

@cgroschupp Do you think you can rebase this PR ?

k8s-ci-robot · 2024-01-03T18:21:09Z

@cgroschupp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-external-dns-licensecheck	`9d3fca0`	link	true	`/test pull-external-dns-licensecheck`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-triage-robot · 2024-04-02T18:48:10Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

nipr-jdoenges · 2024-04-02T18:53:22Z

/remove-lifecycle stale

Evesy · 2024-06-11T07:08:19Z

@cgroschupp Are you still planning to continue with this PR?

@johngmyers Were the changes required to account for #3910 the only outstanding actions stopping this being merged? Keen to see a resolution to #3757 and this PR seems like the best approach so far

k8s-triage-robot · 2024-09-09T07:31:30Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-10-09T08:06:24Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

frittentheke · 2024-10-09T08:16:40Z

/remove-lifecycle rotten

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2023

k8s-ci-robot requested review from johngmyers and szuecs July 10, 2023 14:01

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 10, 2023

cgroschupp force-pushed the new-txt-registry-format branch from 2dab263 to ca4b495 Compare July 10, 2023 14:17

johngmyers reviewed Jul 11, 2023

View reviewed changes

registry/txt.go Outdated Show resolved Hide resolved

cgroschupp force-pushed the new-txt-registry-format branch from 65c013f to 84c7061 Compare July 19, 2023 14:35

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2023

cgroschupp force-pushed the new-txt-registry-format branch from 2fa0d02 to b7b38db Compare August 8, 2023 14:00

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 8, 2023

cgroschupp force-pushed the new-txt-registry-format branch from 3d1a9d4 to d32b169 Compare August 30, 2023 08:58

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 30, 2023

cgroschupp force-pushed the new-txt-registry-format branch from d32b169 to be7d243 Compare August 30, 2023 09:00

johngmyers suggested changes Sep 3, 2023

View reviewed changes

k8s-ci-robot assigned johngmyers Sep 3, 2023

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 5, 2023

cgroschupp added 7 commits September 5, 2023 13:45

add new txt metadata format

4b18fb1

add flag txt-formats

3e03bb3

add transition and only-metadata txt formats

5333b50

remove old txt format for cname records

6bf760b

change txtformat parameter name

6798f12

read metadata in records

319ae92

add apply No prefix Metadata Only test

6c8aaca

johngmyers mentioned this pull request Sep 16, 2023

Change ForceUpdate strategy logic to handle recreations of new txt registry records correctly #3882

Closed

2 tasks

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2023

johngmyers mentioned this pull request Sep 16, 2023

feat(txt-registry): add support for TXT records #3916

Open

1 task

mloiseleur mentioned this pull request Sep 18, 2023

handle apex domain through gandi ALIAS #3855

Closed

2 tasks

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 18, 2023

k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 18, 2023

DP19 mentioned this pull request Sep 29, 2023

Regression - Text registry migration broken on master #3876

Closed

eyvind mentioned this pull request Nov 21, 2023

external-dns continuously deleting and adding the same A and TXT records #4059

Open

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 2, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 2, 2024

mcharriere mentioned this pull request Jul 19, 2024

TXT registry: metadata format #4624

Open

2 tasks

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 9, 2024

darren-recentive mentioned this pull request Sep 14, 2024

CloudFlare provider continuously recreates apex records #4720

Open

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 9, 2024

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 9, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New txt registry format #3774

New txt registry format #3774

cgroschupp commented Jul 10, 2023

johngmyers commented Jul 11, 2023 •

edited

Loading

cgroschupp commented Jul 19, 2023 •

edited

Loading

johngmyers commented Aug 29, 2023

cgroschupp commented Aug 30, 2023

johngmyers left a comment

johngmyers Sep 3, 2023

johngmyers Sep 3, 2023

k8s-ci-robot commented Sep 5, 2023

johngmyers commented Sep 16, 2023

johngmyers commented Sep 18, 2023 •

edited

Loading

k8s-ci-robot commented Sep 18, 2023

johngmyers commented Sep 18, 2023

johngmyers commented Oct 9, 2023

mloiseleur commented Nov 7, 2023

k8s-ci-robot commented Jan 3, 2024

k8s-triage-robot commented Apr 2, 2024

nipr-jdoenges commented Apr 2, 2024

Evesy commented Jun 11, 2024

k8s-triage-robot commented Sep 9, 2024

k8s-triage-robot commented Oct 9, 2024

frittentheke commented Oct 9, 2024

New txt registry format #3774

Are you sure you want to change the base?

New txt registry format #3774

Conversation

cgroschupp commented Jul 10, 2023

johngmyers commented Jul 11, 2023 • edited Loading

cgroschupp commented Jul 19, 2023 • edited Loading

johngmyers commented Aug 29, 2023

cgroschupp commented Aug 30, 2023

johngmyers left a comment

Choose a reason for hiding this comment

johngmyers Sep 3, 2023

Choose a reason for hiding this comment

johngmyers Sep 3, 2023

Choose a reason for hiding this comment

k8s-ci-robot commented Sep 5, 2023

johngmyers commented Sep 16, 2023

johngmyers commented Sep 18, 2023 • edited Loading

k8s-ci-robot commented Sep 18, 2023

johngmyers commented Sep 18, 2023

johngmyers commented Oct 9, 2023

mloiseleur commented Nov 7, 2023

k8s-ci-robot commented Jan 3, 2024

k8s-triage-robot commented Apr 2, 2024

nipr-jdoenges commented Apr 2, 2024

Evesy commented Jun 11, 2024

k8s-triage-robot commented Sep 9, 2024

k8s-triage-robot commented Oct 9, 2024

frittentheke commented Oct 9, 2024

johngmyers commented Jul 11, 2023 •

edited

Loading

cgroschupp commented Jul 19, 2023 •

edited

Loading

johngmyers commented Sep 18, 2023 •

edited

Loading