Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serialization/deserialization support to DomainFilter #3758

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Add serialization/deserialization support to DomainFilter #3758

merged 2 commits into from
Jul 20, 2023

Conversation

johngmyers
Copy link
Contributor

Description

Adds JSON serialization and deserialization support to DomainFilter in preparation for the webhook provider's support for GetDomainFilter.

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 1, 2023
@johngmyers johngmyers changed the title Add serialization/deserialization support to DomainFilter WIP Add serialization/deserialization support to DomainFilter Jul 1, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2023
@johngmyers johngmyers changed the title WIP Add serialization/deserialization support to DomainFilter Add serialization/deserialization support to DomainFilter Jul 1, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2023
@johngmyers johngmyers force-pushed the serialize branch 2 times, most recently from ea27f34 to 790bbe1 Compare July 2, 2023 01:15
@johngmyers
Copy link
Contributor Author

/cc @Raffo

@k8s-ci-robot k8s-ci-robot requested a review from Raffo July 2, 2023 02:41
@Raffo
Copy link
Contributor

Raffo commented Jul 20, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 659c4fb into kubernetes-sigs:master Jul 20, 2023
10 checks passed
@johngmyers johngmyers deleted the serialize branch July 20, 2023 15:08
@johngmyers johngmyers mentioned this pull request Sep 13, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner Awaiting requested review from njuettner

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

@Raffo Raffo Awaiting requested review from Raffo

Assignees

@Raffo Raffo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johngmyers @Raffo @k8s-ci-robot