Remove PropertyValuesEqual method from Provider interface

[johngmyers]

Description

This is prep work for the webhook provider. Removes the frequently-called PropertyValuesEqual method from the Provider and Registry interfaces, requiring providers to normalize provider-specific properties in their AdjustEndpoints method.

Checklist

• Unit tests updated
• End user documentation updated

[Raffo]

@johngmyers In general this looks good to me. One question I have is how can we make sure that we spot any regressions with this change. Do you have access to some of the providers impacted, for example cloudflare?

[johngmyers]

I do not have access to Cloudflare.

To spot AWS regressions I added to the AWS tests assertions that AdjustEndpoints is idempotent over the test data and that the Records expected data is already normalized (modulo records added by normalization, after my AAAA alias PR).

The Cloudflare unit tests do not make assertions about the content of returned records, just their expected number. So I did not attempt to adjust those tests.

[Raffo]

@johngmyers a couple more comments, then we're good to go.

[Raffo]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, mloiseleur, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Raffo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[johngmyers]

/retest