-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Route53 update configuration of target health checks #3674
Route53 update configuration of target health checks #3674
Conversation
16b82ef
to
55bbb29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small comment, the change looks fine to me.
@szuecs can you help with the review of this too?
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, szuecs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Raffo could you LGTM? |
/lgtm |
Description
Fixes the Route53 provider so that it will reconcile changes to the configuration of target health checks on alias records.
Fixes the canonicalization of the
alias
provider-specific property so that the planner will not schedule unnecessary changes.Prepares the Route53 provider for subsequent removal of the
provider.PropertyValuesEqual()
interface method.Checklist
End user documentation updated