Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove provider: plural #3732

Closed
wants to merge 1 commit into from
Closed

remove provider: plural #3732

wants to merge 1 commit into from

Conversation

szuecs
Copy link
Contributor

@szuecs szuecs commented Jun 26, 2023

#3725

waiting two weeks from now for comments in the issue.

@szuecs
remove provider: plural
54ae586 
reason: #3725 use of unlicensed dependency
Signed-off-by: Sandor Szücs <sandor.szuecs@zalando.de>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 26, 2023
@szuecs szuecs added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 26, 2023
johngmyers
johngmyers suggested changes Jun 27, 2023
View reviewed changes
docs/contributing/crd-source/crd-manifest.yaml
@@ -13,7 +13,6 @@ spec:
names:
kind: DNSEndpoint
listKind: DNSEndpointList
plural: dnsendpoints
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has nothing to do with the plural provider. It should be kept

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is pure CRD and must be kept, not related to the provider.

docs/contributing/crd-source/crd-manifest.yaml
@@ -89,6 +88,5 @@ spec:
status:
acceptedNames:
kind: ""
plural: ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be kept.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2023
@johngmyers
Copy link
Contributor

@szuecs you should comment /approve cancel if you don't want k8s-ci-robot to re-add the approved label.

@johngmyers
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 27, 2023
@johngmyers
Copy link
Contributor

Putting "WIP" in the title of the PR is a good way for a PR author to prevent merging.

@davidspek
Copy link
Contributor

Sorry for the late response here. We've added the license file to the repo so this PR can be closed.

@davidspek davidspek mentioned this pull request Jul 12, 2023
Merged
2 tasks
@davidspek
Copy link
Contributor

Please see #3779 that should resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers requested changes

@njuettner njuettner Awaiting requested review from njuettner

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@szuecs @k8s-ci-robot @johngmyers @davidspek @njuettner