Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update plural client that includes license #3779

Merged

Conversation

davidspek
Copy link
Contributor

@davidspek davidspek commented Jul 12, 2023

Description

This PR updates the version of the Plural GQLClient to one that includes the Apache 2.0 license.
Once again we'd like to apologize for the trouble caused here. We're mainly using the client internally and as such didn't think about adding a license and we missed the issue that was raised on the client repository.

/cc @tylerschultz @szuecs

Fixes #3725
Closes #3732

Checklist

  • Unit tests updated
  • End user documentation updated

Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
@k8s-ci-robot k8s-ci-robot requested a review from szuecs July 12, 2023 15:45
@k8s-ci-robot
Copy link
Contributor

@davidspek: GitHub didn't allow me to request PR reviews from the following users: tylerschultz.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Description

This PR updates the version of the Plural GQLClient to one that includes the Apache 2.0 license.
Once again we'd like to apologize for the trouble caused here. We're mainly using the client internally and as such didn't think about adding a license and we missed the issue that was raised on the client repository.

/cc @tylerschultz @szuecs

Fixes #3725
Closes #3732

Checklist

  • Unit tests updated
  • End user documentation updated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 12, 2023
@johngmyers
Copy link
Contributor

/ok-to-test
/lgtm
/assign @seanmalloy

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 13, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2023
@seanmalloy
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit ff09e60 into kubernetes-sigs:master Jul 13, 2023
14 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidSpek, seanmalloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency pluralsh/gqlclient has no LICENSE file
4 participants