Add a flag that allows FQDN and Annotations to combine #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
@helgi can you rebase to the latest master? |
Old behaviour is kept by default, a new flag is introduced to combine instead of overwrite Fixes kubernetes-sigs#218
helgi
force-pushed
the
feature/combine-fqdn-annotation
branch
from
32bba0a
to
6912bbf
Compare
|
@hjacobs done |
|
lgtm |
|
👍 |
lou-lan
pushed a commit
to lou-lan/external-dns
that referenced
this pull request
May 11, 2022
…s#513) * Use static URL to download assets from latest release This also simplifies the release process for krew, because the version number does not need to be updated when releasing a new version. * Create release commit instead of tagging a random one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old behaviour is kept by default, a new flag is introduced to combine instead of overwriting
Fixes #218
Depends on #512