[WIP] conformance: add local filesystem path support to getContentsFromPathOrURL helper

[mikemorris]

What type of PR is this?
/kind feature

What this PR does / why we need it:
Consul API Gateway currently needs to slightly tweak the conformance tests base manifests with kustomize (to add an annotation to Deployments and reduce replicas to 1 due to resource limitations in GitHub Actions). Specifying a string path for BaseManifests is currently supported as an option when initializing a ConformanceTestSuite struct, but unless the string is a remote path beginning with https://, it is hardcoded to only read from the read-only embedded filesystem.

This is currently marked as WIP as it may need some additional input validation checks.

Open to alternative approaches (I thought of a few possible options over in #1180 (comment)) and don't mind reworking if needed.

Which issue(s) this PR fixes:
Fixes #1180

Does this PR introduce a user-facing change?:

conformance: allow configuring BaseManifests from local filesystem with "local://" path prefix

[k8s-ci-robot]

Hi @mikemorris. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mikemorris
To complete the pull request process, please assign youngnick after the PR has been reviewed.
You can assign the PR to them by writing /assign @youngnick in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[youngnick]

/ok-to-test

[youngnick]

I think the URL-style approach is fine, and we can just document that unprefixed filenames are assumed to be in the embedded filesystem. I added some commends on #1180 about what validation I think we should do for the filenames.

[robscott]

@mikemorris is this still something you want to get in? It looks like it's still in WIP state, is that intentional? Does John's related PR help here?

[mikemorris]

@robscott I just wasn't quite sure how to best implement the safeguards mentioned in #1180 (comment)

This is currently marked as WIP as it may need some additional input validation checks.

#1069 is the limitation I'm trying to get around - only the files in tests and base are included in the embedded filesystem when using gateway-api as a library to run the conformance suite.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.