-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] conformance: add local filesystem path support to getContentsFromPathOrURL helper #1198
Conversation
Hi @mikemorris. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mikemorris The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
I think the URL-style approach is fine, and we can just document that unprefixed filenames are assumed to be in the embedded filesystem. I added some commends on #1180 about what validation I think we should do for the filenames. |
@mikemorris is this still something you want to get in? It looks like it's still in WIP state, is that intentional? Does John's related PR help here? |
@robscott I just wasn't quite sure how to best implement the safeguards mentioned in #1180 (comment)
#1069 is the limitation I'm trying to get around - only the files in |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Consul API Gateway currently needs to slightly tweak the conformance tests base manifests with kustomize (to add an annotation to Deployments and reduce replicas to 1 due to resource limitations in GitHub Actions). Specifying a string path for
BaseManifests
is currently supported as an option when initializing aConformanceTestSuite
struct, but unless the string is a remote path beginning withhttps://
, it is hardcoded to only read from the read-only embedded filesystem.This is currently marked as WIP as it may need some additional input validation checks.
Open to alternative approaches (I thought of a few possible options over in #1180 (comment)) and don't mind reworking if needed.
Which issue(s) this PR fixes:
Fixes #1180
Does this PR introduce a user-facing change?: