-
Notifications
You must be signed in to change notification settings - Fork 17
Conversation
dd6f399
to
415af3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ignore]
313218d
to
b648987
Compare
Well this is now compiling/linting again after all the restructuring and dependency updates, but seems to be getting stuck spinning up the base manifests resources (due to resource constraints?) |
After chatting with @nathancoleman realized that the kustomization wasn't actually being applied (needed to write the output back to disk and pass that path as I am planning to pull out a few non-relevant changes that could merge separately (like the |
1c8acbd
to
6363951
Compare
@mikemorris I'm a little fuzzy on this one. Is it something we still need to merge or should it be closed? |
A substantial chunk of this was implemented in #224, the rest is blocked on kubernetes-sigs/gateway-api#1198 currently, probably makes most sense to close this and open a fresh PR later. |
Changes proposed in this PR:
Implement our own test runner for the conformance test suite that has a known list of tests to skip. This substantially changes how we approach patching the base manifests now that we're not running the conformance suite from within a local checkout - we apply the kustomzie patch using the
krusty
library instead of using the CLI.How I've tested this PR:
Notes for reviewers
go.mod
updates to k8s.io modules are due to adding the dependency onkyaml
which switches fromgoogleapis/gnostic
togoogle/gnostic
- this was handled in Update kubectl kustomize to v4.5.4 kubernetes/kubernetes#108994 to resolve the dependency conflict, but requires updating all dependencies in lockstepinternal/k8s/logger.go
changes are to adapt to the breaking change in Rearch for performance: BREAKING CHANGES go-logr/logr#42 hit due to the dependency bump to go-logr/logr from updating the Kubernetes ecosystem librariesHow I expect reviewers to test this PR:
main
branch of the Helm chart source (catches breaking changes earlier, requires keepingglobal.imageK8S: "docker.mirror.hashicorp.services/hashicorpdev/consul-k8s-control-plane:latest"
inconsul-config.yaml
) or latest published release from thehashicorp
Helm repository (incompatible with specifyinglatest
tag forglobal.imageK8s
)maxTimeToConsistency
in thesuite.go
file we're reimplementing instead of relying on a fork?Checklist:
addedskippedCHANGELOG entry added