This repository has been archived by the owner on Mar 19, 2024. It is now read-only.
conformance: skip failing tests without 60s timeout #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemorris
added
the
pr/no-changelog
mikemorris
force-pushed
the
conformance/skipped-tests-without-60s-timeout
branch
from
85409fd
to
45906e8
Compare
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Update the conformance testing workflow to checkout an updated branch on the hashicorp/gateway-api fork with a few failing tests skipped, and the current 60s timeout removed.
The longer-term plan will be to integrate the conformance suite directly as in #205 rather than relying on a fork, but we're holding off on that until gateway-api tags a v0.5.0 release.
How I've tested this PR:
Observed the conformance tests are now passing.
How I expect reviewers to test this PR:
Verify that this change is an adequate short-term resolution.
Checklist:
Tests addedCHANGELOG entry added