Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

conformance: update hashicorp fork to skip failing tests #218

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

mikemorris
Copy link
Contributor

@mikemorris mikemorris commented Jun 9, 2022

Changes proposed in this PR:

Update the conformance testing workflow to checkout an updated branch on the hashicorp/gateway-api fork with a few failing tests skipped.

The longer-term plan will be to integrate the conformance suite directly as in #205 rather than relying on a fork, but we're holding off on that until gateway-api tags a v0.5.0 release.

How I've tested this PR:

Observed the conformance tests are now passing.

How I expect reviewers to test this PR:

Verify that this change is an adequate short-term resolution.

Checklist:

  • Tests added
  • CHANGELOG entry added

    Run make changelog-entry for guidance in authoring a changelog entry, and
    commit the resulting file, which should have a name matching your PR number.
    Entries should use imperative present tense (e.g. Add support for...)

@mikemorris mikemorris added the pr/no-changelog Skip the CI check that requires a changelog entry label Jun 9, 2022
@mikemorris mikemorris closed this Jun 9, 2022
@mikemorris mikemorris deleted the conformance/update-hashicorp-fork branch June 9, 2022 20:57
@mikemorris mikemorris restored the conformance/update-hashicorp-fork branch June 9, 2022 21:41
@mikemorris
Copy link
Contributor Author

Reopened this due to two tests timing out over in #217 which appear to still need the 60s window.

     --- FAIL: TestConformance/HTTPRouteMatchingAcrossRoutes (1.04s)
        --- FAIL: TestConformance/HTTPRouteMatchingAcrossRoutes/7_request_to_example.com/_with_headers_should_go_to_infra-backend-v2 (30.00s)
        --- FAIL: TestConformance/HTTPRouteMatchingAcrossRoutes/0_request_to_example.com/_should_go_to_infra-backend-v1 (30.00s)

@mikemorris mikemorris reopened this Jun 9, 2022
@mikemorris mikemorris marked this pull request as ready for review June 9, 2022 21:58
@mikemorris mikemorris requested a review from a team June 9, 2022 21:58
@mikemorris mikemorris merged commit a4cabc8 into main Jun 13, 2022
@mikemorris mikemorris deleted the conformance/update-hashicorp-fork branch June 13, 2022 11:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr/no-changelog Skip the CI check that requires a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants