-
Notifications
You must be signed in to change notification settings - Fork 39.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kubectl kustomize to v4.5.4 #108994
Conversation
@KnVerey: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The test failure is because we improved an error message in kustomize, I think you just need to update the expected error in TestKustomizeDirectoryBuilder and it should be good to go. |
/retest |
/lgtm |
/cc @liggitt |
vendor/modules.txt
Outdated
@@ -2549,6 +2550,7 @@ sigs.k8s.io/yaml | |||
# github.com/google/shlex => github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 | |||
# github.com/google/uuid => github.com/google/uuid v1.1.2 | |||
# github.com/googleapis/gax-go/v2 => github.com/googleapis/gax-go/v2 v2.0.5 | |||
# github.com/googleapis/gnostic => github.com/googleapis/gnostic v0.5.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was just moved to github.com/google/gnostic in #108644 (specifically the v0.5.7-v3refs revision to avoid tons of transitive dependencies in google/gnostic#317) ... can we avoid reintroducing two names / versions for the same dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @Jefftree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, and I'm sorry for missing this. We'll make the same change on our side (kubernetes-sigs/kustomize#4538), release again, and update this PR to use the fixed versions.
bump looks good, addition of duplicate gnostic dep is problematic and should be resolved before merge |
excellent, check-dependency-stats shows no new deps /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KnVerey, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-e2e-kind |
/test pull-kubernetes-e2e-kind-ipv6 |
Rebased. |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Updates Kustomize to v4.5.4, which we released today, so that kubectl v1.24 will include it.
Which issue(s) this PR fixes:
n/a
Special notes for your reviewer:
Updated using the new
hack/update-kustomize.sh
script!Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/cc @natasha41575