Remove generate target from build, run and test targets

[a-hilaly]

Addresses #222

This patch removes generate target from build, run and test targets.

[k8s-ci-robot]

Hi @a-hilaly. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[a-hilaly]

I found that there is already a generate target. I'm not super sure if this is what we need here. Do we want to add a script to only call make generate if the APIs changed?

/assign @kannon92 @danielvegamyhre

[kannon92]

I found that there is already a generate target. I'm not super sure if this is what we need here. Do we want to add a script to only call make generate if the APIs changed?

/assign @kannon92 @danielvegamyhre

Kinda. We want to verify that API changed and generate needs to be called. I think we have something in verify that does this for our manifests.

[kannon92]

jobset/Makefile

Line 121 in a5f3ee3

verify: vet fmt-verify manifests generate

Is an example

[kannon92]

/ok-to-test

[danielvegamyhre]

@a-hilaly Thanks for doing this. Can you confirm that if you make a change to the API Go code without running make generate afterwards, that the command make verify fails? If so, I think we should be good to merge this.

[a-hilaly]

@a-hilaly Thanks for doing this. Can you confirm that if you make a change to the API Go code without running make generate afterwards, that the command make verify fails? If so, I think we should be good to merge this.

I can confirm make verify fails if we don't run make generate after an api change

[a-hilaly]

Kinda. We want to verify that API changed and generate needs to be called. I think we have something in verify that does this for our manifests.

I can add a new rule auto-generate that will ony execute the generation rules if verify fails.. what do you think about this?

Or maybe we can just call verify early in run, build and test targets?

[kannon92]

Kinda. We want to verify that API changed and generate needs to be called. I think we have something in verify that does this for our manifests.

I can add a new rule auto-generate that will ony execute the generation rules if verify fails.. what do you think about this?

Or maybe we can just call verify early in run, build and test targets?

I don't think we need to do this. I think we are okay with requiring someone to run make generate if their verify step fails in the CI.

[kannon92]

/lgtm

With make verify failing if one changes the API I think this solves @danielvegamyhre concern.

[danielvegamyhre]

/approve

Thanks for working on this!

I don't think we need to do this. I think we are okay with requiring someone to run make generate if their verify step fails

Agreed we don't need this.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, danielvegamyhre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [danielvegamyhre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment