Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generate target from build, run and test targets #228

Merged
merged 1 commit into from
Jul 20, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ vet: ## Run go vet against code.
$(GO_CMD) vet ./...

.PHONY: test
test: manifests generate fmt vet envtest gotestsum test-python-sdk
test: manifests fmt vet envtest gotestsum test-python-sdk
KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir $(LOCALBIN) -p path)" $(GOTESTSUM) --junitfile $(ARTIFACTS)/junit.xml -- ./pkg/... ./api/... -coverprofile $(ARTIFACTS)/cover.out

.PHONY: test-python-sdk
Expand All @@ -125,11 +125,11 @@ verify: vet fmt-verify manifests generate
##@ Build

.PHONY: build
build: manifests generate fmt vet ## Build manager binary.
build: manifests fmt vet ## Build manager binary.
$(GO_CMD) build -o bin/manager main.go

.PHONY: run
run: manifests generate fmt vet ## Run a controller from your host.
run: manifests fmt vet ## Run a controller from your host.
$(GO_CMD) run ./main.go

# Build the container image
Expand Down Expand Up @@ -246,12 +246,12 @@ kind-image-build: IMAGE_BUILD_EXTRA_OPTS=--load
kind-image-build: kind image-build

.PHONY: test-integration
test-integration: manifests generate fmt vet envtest ginkgo ## Run tests.
test-integration: manifests fmt vet envtest ginkgo ## Run tests.
KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) -p path)" \
$(GINKGO) --junit-report=junit.xml --output-dir=$(ARTIFACTS) -v $(INTEGRATION_TARGET)

.PHONY: test-e2e-kind
test-e2e-kind: manifests generate kustomize fmt vet envtest ginkgo kind-image-build
test-e2e-kind: manifests kustomize fmt vet envtest ginkgo kind-image-build
E2E_KIND_VERSION=$(E2E_KIND_VERSION) KIND_CLUSTER_NAME=$(KIND_CLUSTER_NAME) USE_EXISTING_CLUSTER=$(USE_EXISTING_CLUSTER) ARTIFACTS=$(ARTIFACTS) IMAGE_TAG=$(IMAGE_TAG) ./hack/e2e-test.sh

.PHONY: prometheus
Expand Down