-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add suspend field to printcolumn #400
Conversation
Maybe kubernetes/test-infra#31889 is related to these failures... |
/cc @danielvegamyhre |
I think this would be useful to have. Looks like the current implementation results in a nil dereference error, though. |
Are you bringing up the seg fault? I am getting the same failure in the startup policy. I tested this and it worked with specifiy suspend: true, suspend:false and not specifying it. |
I had a feeling something is up with the CI because I am getting the same error in #246. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Kevin, one suggestion.
308df15
to
c92ad5a
Compare
@kannon92: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, kannon92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/restart |
1 similar comment
/restart |
/retest |
Fixes #399