Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase NodePool requirements maxItems #1270

Open
NetanelK opened this issue May 21, 2024 · 3 comments
Open

Increase NodePool requirements maxItems #1270

NetanelK opened this issue May 21, 2024 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@NetanelK
Copy link

Description

What problem are you trying to solve?
While working on aws/karpenter-provider-aws#5779 I've reached the maximum limit of 30 requirements per node pool, to support more requirements from providers, the maxItems limit needs to be increased.

karpenter-provider-aws tests should support combined instance type labels.

How important is this feature to you?
This feature is needed to expand karpenter abilities to select instances more granularly.

I'd be happy to contribute this small adjustment if approved.

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@NetanelK NetanelK added the kind/feature Categorizes issue or PR as related to a new feature. label May 21, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Karpenter contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 21, 2024
@NetanelK
Copy link
Author

cc @jonathan-innis

@jmdeal
Copy link
Member

jmdeal commented Jun 17, 2024

I believe this limit had to do with CEL limitations around cost estimation. @engedaam do you remember if this was the original reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

3 participants