feat: Add ability to select instance by performance mode #5779
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
NetanelK
force-pushed
the
feature/performance-mode-selection
branch
3 times, most recently
from
b3b4cad
to
732742a
Compare
NetanelK
force-pushed
the
feature/performance-mode-selection
branch
from
732742a
to
bd4dbd2
Compare
Pull Request Test Coverage Report for Build 8152705293Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
NetanelK
force-pushed
the
feature/performance-mode-selection
branch
from
bd4dbd2
to
eb96063
Compare
NetanelK
force-pushed
the
feature/performance-mode-selection
branch
from
eb96063
to
793fb4b
Compare
| @@ -114,6 +118,7 @@ var ( | |||
| LabelInstanceAcceleratorName = Group + "/instance-accelerator-name" | |||
| LabelInstanceAcceleratorManufacturer = Group + "/instance-accelerator-manufacturer" | |||
| LabelInstanceAcceleratorCount = Group + "/instance-accelerator-count" | |||
| LabelInstancePerformanceMode = Group + "/instance-performance-mode" | |||
There was a problem hiding this comment.
| LabelInstancePerformanceMode = Group + "/instance-performance-mode" | |
| LabelInstancePerformanceMode = Group + "/instance-capability-flex" |
Suggesting this label name in the original issue because of the way that EC2 describes their own naming convention here: https://docs.aws.amazon.com/ec2/latest/instancetypes/instance-type-names.html. Given that page as well, I'm not sure that it makes sense to couple the burstable instance types with the flex ones. Can we treat flex as its own thing here?
There was a problem hiding this comment.
Personally I would prefer a value that can be fetched from the EC2 API, instead of relaying on the instance name structure.
Anyhow, it can be done fairly easy.
There was a problem hiding this comment.
I tried to add a label per each instance capability (total 7) and encountered the following error:
"NodeClaim.karpenter.sh \"spiritslow-94-ywrmgisn0j-p88dm\" is invalid: [spec.requirements: Too many: 31: must have at most 30 items, <nil>: Invalid value: \"null\": some validation rules were not checked because the object was invalid; correct the existing errors to complete validation]"
The cause is this line from kubernetes-sigs/karpenter, can we increase the limit of requirements?
New code for reference main...NetanelK:karpenter-provider-aws:feature/instance-additional-capablities
|
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
|
Closing in favor of #6294 |
Fixes #4367
Description
Added ability to select instance by its performance mode, either
flex,burstable, orstandard.By using the label
karpener.k8s.aws/instance-performance-modeHow was this change tested?
Ran unit tests
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.