-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability to select instances by additonal capabilities #6294
base: main
Are you sure you want to change the base?
feat: Add ability to select instances by additonal capabilities #6294
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
be37513
to
32d41a5
Compare
32d41a5
to
aed6b1c
Compare
@NetanelK I think we want to keep the number of capabilities that we add here to be tightly scoped here to start. It's probably best if we broke out the PRs for each of the "capabilities" that we add so that we can consider them individually. How do you feel about opening separate PRs -- one for flex capability and another for the network optimized capability? |
It's reasonable to separate flex capacity from the other ones, I'll do that, but I think that most of the capacities can be added right away instead of waiting for specific requests, as the regex includes them all. I can drop the |
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
I'd prefer not using the implementation as a reason to add externally facing API. I'm agreed that we can add a mechanism (at a minimum) to select (or deselect) flex. I'm still in favor of just scoping this PR to do that, then we don't have to block on a bunch of other discussion around the merits of selecting on storage-optimized or network-optimized and the use-cases for them. |
I'm trying to do that careful balance of trying not to generate too much churn for you @NetanelK while also making sure that we are accurately understanding and capturing use-cases for new externally-facing API. Apologize that this will create more churn for you, but I do think that it should make the audit trail of each of these features going in easier to track and should facilitate more discussion from the community. |
This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity. |
Fixes #4367
Fixes #6122
Description
This PR adds 7 instance capabilities selectors based on AWS Naming Conventions
How was this change tested?
As Karpenter supports up to 30 requirements, instancetype suite test doesn't pass, refer to issue kubernetes-sigs/karpenter#1270
Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.