Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ability to select instances by additonal capabilities #6294

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NetanelK
Copy link
Contributor

Fixes #4367
Fixes #6122

Description
This PR adds 7 instance capabilities selectors based on AWS Naming Conventions

How was this change tested?
As Karpenter supports up to 30 requirements, instancetype suite test doesn't pass, refer to issue kubernetes-sigs/karpenter#1270

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

netlify bot commented May 30, 2024

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit aed6b1c
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/665c1c6c2ab98500080b51d8
😎 Deploy Preview https://deploy-preview-6294--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NetanelK NetanelK force-pushed the feature/instance-additional-capablities branch from be37513 to 32d41a5 Compare May 30, 2024 13:35
@NetanelK NetanelK marked this pull request as ready for review June 2, 2024 07:16
@NetanelK NetanelK requested a review from a team as a code owner June 2, 2024 07:16
@NetanelK NetanelK requested a review from ellistarn June 2, 2024 07:16
@NetanelK NetanelK force-pushed the feature/instance-additional-capablities branch from 32d41a5 to aed6b1c Compare June 2, 2024 07:16
@jonathan-innis
Copy link
Contributor

@NetanelK I think we want to keep the number of capabilities that we add here to be tightly scoped here to start. It's probably best if we broke out the PRs for each of the "capabilities" that we add so that we can consider them individually. How do you feel about opening separate PRs -- one for flex capability and another for the network optimized capability?

@NetanelK
Copy link
Contributor Author

NetanelK commented Jun 5, 2024

@NetanelK I think we want to keep the number of capabilities that we add here to be tightly scoped here to start. It's probably best if we broke out the PRs for each of the "capabilities" that we add so that we can consider them individually. How do you feel about opening separate PRs -- one for flex capability and another for the network optimized capability?

It's reasonable to separate flex capacity from the other ones, I'll do that, but I think that most of the capacities can be added right away instead of waiting for specific requests, as the regex includes them all.

I can drop the q and z capabilities if you want as they are less used, the other ones like b, d, e, and n are used more (in my workplace we need to be able to get the n and d instances), so I would like to keep them.

Copy link
Contributor

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

@jonathan-innis
Copy link
Contributor

can be added right away instead of waiting for specific requests, as the regex includes them all

I'd prefer not using the implementation as a reason to add externally facing API. I'm agreed that we can add a mechanism (at a minimum) to select (or deselect) flex. I'm still in favor of just scoping this PR to do that, then we don't have to block on a bunch of other discussion around the merits of selecting on storage-optimized or network-optimized and the use-cases for them.

@jonathan-innis
Copy link
Contributor

I'm trying to do that careful balance of trying not to generate too much churn for you @NetanelK while also making sure that we are accurately understanding and capturing use-cases for new externally-facing API. Apologize that this will create more churn for you, but I do think that it should make the audit trail of each of these features going in easier to track and should facilitate more discussion from the community.

Copy link
Contributor

github-actions bot commented Jul 8, 2024

This PR has been inactive for 14 days. StaleBot will close this stale PR after 14 more days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants