Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to enable feature gates #572

Merged
merged 2 commits into from
Jun 5, 2019
Merged

Document how to enable feature gates #572

merged 2 commits into from
Jun 5, 2019

Conversation

aojea
Copy link
Contributor

@aojea aojea commented May 29, 2019

Describe how to enable different gates in your kind cluster patching kubeadm

Fixes #563

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 29, 2019
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 29, 2019
@aojea
Copy link
Contributor Author

aojea commented May 29, 2019

/assign @neolit123

neolit123
neolit123 reviewed May 29, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2019
tao12345666333
tao12345666333 reviewed May 29, 2019
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@aojea
Copy link
Contributor Author

aojea commented May 29, 2019

/assign @BenTheElder

matthyx
matthyx reviewed Jun 1, 2019
View reviewed changes
site/content/docs/user/quick-start.md Outdated
name: config
apiServer:
extraArgs:
"feture-gates": "FeatureGateName=true"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really spelled feture-gates? I haven't found anywhere in k/k this way of writing feature...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch, thanks

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2019
BenTheElder
BenTheElder reviewed Jun 4, 2019
View reviewed changes
site/content/docs/user/quick-start.md
@@ -242,6 +242,49 @@ nodes:
- role: worker
```

### Enable Feature Gates in Your Cluster
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be in another page? the "quick start" seems to be covering a lot now 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, but I think that we should first thing how do we want to reorganize the docs, seems that they are starting to grow and I think that adding an advanced section with this stuff is not a good solution because we are going to have the same problem after some time.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, BenTheElder

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit 30fb7b1 into kubernetes-sigs:master Jun 5, 2019
@aojea aojea mentioned this pull request Jun 14, 2019
Closed
@tao12345666333 tao12345666333 mentioned this pull request Jun 26, 2019
Closed
@aojea aojea deleted the gates branch August 9, 2020 08:45
stg-0 pushed a commit to stg-0/kind that referenced this pull request Jul 31, 2024
@esierra-stratio
prepare release (kubernetes-sigs#572)
db55c79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthyx matthyx matthyx left review comments

@tao12345666333 tao12345666333 tao12345666333 left review comments

@neolit123 neolit123 neolit123 left review comments

@BenTheElder BenTheElder BenTheElder approved these changes

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@neolit123 neolit123

@BenTheElder BenTheElder

@tao12345666333 tao12345666333

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using Feature Gates
6 participants
@aojea @k8s-ci-robot @neolit123 @BenTheElder @tao12345666333 @matthyx