doc: configuring kubelet garbage collection #663
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tao12345666333 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/S
| @@ -363,6 +363,30 @@ The structure of the logs will look more or less like this: | |||
| The logs contain information about the Docker host, the containers running | |||
| kind, the Kubernetes cluster itself, etc. | |||
|
|
|||
| ### Configuring kubelet Garbage Collection in Your Cluster | |||
There was a problem hiding this comment.
I can see documenting this being useful, but this is pretty far into "quick-start has way too much in it"
There was a problem hiding this comment.
yes. I have the same opinion as @aojea . #572 (comment)
we should first thing how do we want to reorganize the docs, seems that they are starting to grow and I think that adding an advanced section with this stuff is not a good solution because we are going to have the same problem after some time.
There was a problem hiding this comment.
in addition to this PR, I see that we have some documentation on how to use kind in CI or some extra advanced features, which may need to be reorganized.
There was a problem hiding this comment.
kind in CI is now in the resources doc
I also don't think this is safe to enable in kind. it can evict the core images.
k8s-ci-robot
added
the
needs-rebase
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
tao12345666333
force-pushed
the
config-kubelet-gc
branch
from
9690473 to
2261f17
Compare
k8s-ci-robot
removed
the
needs-rebase
|
@tao12345666333: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
so I forgot to follow up here but I've followed up more with SIG-node about this. currently kubernetes has a gap in this -- airgapped images that are sideloaded (like kind's) are image-gc unsafe. we should provide a different option, I will think on it some more, but this is too much of a footgun for users. |
k8s-ci-robot
added
the
needs-rebase
|
@tao12345666333: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
xref: #658