Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slurm] Fix error description on multiple parallel tasks with more than one step error. #54

Merged

Conversation

mbobrovskyi
Copy link
Contributor

@mbobrovskyi mbobrovskyi commented Feb 5, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix error description on multiple parallel tasks with more than one step error on Slurm mode.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 5, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 5, 2025
@mbobrovskyi
Copy link
Contributor Author

cc: @mwysokin

@mbobrovskyi mbobrovskyi changed the title Fix error description on multiple parallel tasks with more than one step error. [Slurm] Fix error description on multiple parallel tasks with more than one step error. Feb 5, 2025
@mbobrovskyi mbobrovskyi force-pushed the fix/error-description branch from 73176a4 to ee81e15 Compare February 5, 2025 06:51
@mbobrovskyi
Copy link
Contributor Author

/cc @IrvingMg

@k8s-ci-robot k8s-ci-robot requested a review from IrvingMg February 5, 2025 06:54
@IrvingMg
Copy link
Contributor

IrvingMg commented Feb 5, 2025

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 114fcd1d43ae620428a4a64ac047738554e5523f

Copy link

@mwysokin mwysokin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🖖

@mimowo
Copy link
Contributor

mimowo commented Feb 5, 2025

/approve
Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: IrvingMg, mbobrovskyi, mimowo, mwysokin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2025
@k8s-ci-robot k8s-ci-robot merged commit a0a8a21 into kubernetes-sigs:main Feb 5, 2025
6 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.2 milestone Feb 5, 2025
@mbobrovskyi mbobrovskyi deleted the fix/error-description branch February 5, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants