Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Slurm] Fix error description on multiple parallel tasks with more than one step error. #54

Merged
merged 1 commit into from
Feb 5, 2025
+2 −2
Merged

[Slurm] Fix error description on multiple parallel tasks with more than one step error. #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/parser/slurm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ func SlurmValidateAndReplaceScript(script string, nTasks int32) (string, error)
}

if nTasks > 1 && srunCount > 0 {
return "", errors.New("multiple parallel tasks with a task count greater than 1 are not supported yet")
return "", errors.New("multiple parallel tasks with more than one step are not supported yet")
}

if index := findCommand(line, srunCommand); index != -1 {
Expand Down
2 changes: 1 addition & 1 deletion pkg/parser/slurm_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ srun -n 4 -c 1 my_program_4 &
wait
`,
nTasks: 8,
wantErr: "multiple parallel tasks with a task count greater than 1 are not supported yet",
wantErr: "multiple parallel tasks with more than one step are not supported yet",
},
"srun must specified at lease one argument": {
script: "#!/bin/bash\nsrun",
Expand Down