Cm beta.6, a plugin for Red Hat Advanced Cluster Management

[itdove]

No description provided.

[ahmetb]

I see the project is new and you folks chose the name "cm". It doesn't go against our guidelines but wanna make sure it doesn't hurt discoverability for you.

[itdove]

@ahmetb Thanks for the advice, we good with that short name as we think people will discover the CLI through the product and not the other way around.
Many thanks

[itdove]

@ahmetb The test failed because I had a typo on ppc64le, fixed it.

[itdove]

@ahmetb You don't support this platform:

1962 main.go:62] spec.platform[3]'s selector (&LabelSelector{MatchLabels:map[string]string{arch: ppc64le,os: linux,},MatchExpressions:[]LabelSelectorRequirement{},}) doesn't match any supported platforms

however it is in the list

go tool dist list

[ahmetb]

We don’t support krew on all platforms yet.
That’s why it wouldn’t be installed via Krew. Does that make sense?

[itdove]

@ahmetb makes sense but the doc mentions

The possible values for os and arch come from the Go runtime. Run go tool dist list to see all possible platforms and architectures.

at https://krew.sigs.k8s.io/docs/developer-guide/plugin-manifest/

is the ppc64le the only one I listed in the manifest which is not supported or there is some others?
Removing the ppc64le...

[ahmetb]

You're definitely right!

Krew does support installing to that platform (e.g. you can override the detected platform via KREW_OS and KREW_ARCH). But it seems our manifest validation tool for krew-index repo checks for the platforms Krew itself is distributed for. https://github.com/kubernetes-sigs/krew/blob/b75099469b59e82d2ca3336f13cb32a498063c78/cmd/validate-krew-manifest/main.go#L230-L244

I think we should maybe relax this or revisit the docs. That said, people don't hit this much yet.

It seems that you have another validation failure now. (s390 is also not supported.)

[itdove]

@ahmetb Thank you, no worries, I removed s390... if really necessary end-user can download directly the release.
thx

[ahmetb]

/lgtm
/approve

Also, please consider setting up Krew release automation which helps you skip manually making updates to your Krew manifests on each new version and send a pull request. It’s a GitHub workflow bot that can run every time you push a new tag. Those PRs are automatically approved.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, itdove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahmetb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[itdove]

@ahmetb Retriger because missing the LICENSE

[ahmetb]

Windows platform has an issue (see test logs).

[itdove]

@ahmetb now we good ;-)

[ahmetb]

/lgtm