Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ppc64le support #755

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Add ppc64le support #755

merged 2 commits into from
Aug 22, 2022

Conversation

mgiessing
Copy link
Contributor

Fixes #...
Related issue: #...

Added support for ppc64le architecture and therefore not really a feature content-wise

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 4, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @mgiessing!

It looks like this is your first PR to kubernetes-sigs/krew 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 4, 2022
@prb112
Copy link

prb112 commented Mar 31, 2022

HI All, I'm a ppc64le user and would like to follow along on this work. Is there a thread to follow/discussion on updates?

@mgiessing
Copy link
Contributor Author

@soltysh can you approve or tell me what needs to be changed in order to merge?

@ahmetb
Copy link
Member

ahmetb commented Mar 31, 2022

Sorry, I forgot to review this one. I don't know much about ppc architecture. Can you please explain how it is used on developer/operator machines where kubectl plugins would be installed? I'm trying to distinguish if it is more of a server architecture than it is for dev machines.

@prb112
Copy link

prb112 commented Mar 31, 2022

@ahmetb the ppc64le architecture is used as a foundation for OpenShift nodes. The kubectl is used mainly by the operators to manage the environment from either a jump server/bastion server.

I hope this helps. @mgiessing may have more to add/or a different view point.

@mgiessing
Copy link
Contributor Author

You've brought it to the point! Besides OpenShift, ppc64le can of course also be used as the foundation for "vanilla" Kubernetes. As indicated by @prb112 kubectl is in this context mainly used by the operators of such a cluster. Since Power has a strong focus on Linux & open source this commit was part of the upstreaming work in kubespray to enable ppc64le along many of its components (e.g. krew).

@ahmetb
Copy link
Member

ahmetb commented Mar 31, 2022

Thanks for the explanation.

The kubectl is used mainly by the operators to manage the environment from either a jump server/bastion server.

Do you think people actually install kubectl plugins (i.e. convenience tools) to the bastion/jump servers? Nearly none of the kubectl plugins are not thoroughly vetted from a security perspective and I am hoping people don't run plugins from their bastion servers.

This has no extra cost to us, but I'd love to really understand which plugins you'll install with this. Today, none of the plugins distribute for ppc64le and I believe the only submission we ever got was from Red Hat, so I'm trying to ensure there's actually >1 users who need this.

@prb112
Copy link

prb112 commented Apr 4, 2022

Hi @ahmetb yes - I think it'll be installed more frequently and in more cases. Thank you for asking. Thanks, Paul

@prb112
Copy link

prb112 commented May 2, 2022

Hi @ahmetb here is an example I hit today. I went to install the minio operator, and it requires the krew plugin before I can install it.

Many thanks, and I hope this helps further this PR

Paul

@ahmetb
Copy link
Member

ahmetb commented May 2, 2022

Thanks, yeah we should probably add.
Also keep in mind that minio operator probably doesn't offer a binary for this platform because up until now, we didn't distribute krew for it. So those plugins have to update their manifests here in krew-index.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 31, 2022
@mkumatag
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 22, 2022
@mkumatag
Copy link
Member

Thanks, yeah we should probably add.
Also keep in mind that minio operator probably doesn't offer a binary for this platform because up until now, we didn't distribute krew for it. So those plugins have to update their manifests here in krew-index.

@ahmetb wondering if we can merge this PR if no further comments?

@ahmetb
Copy link
Member

ahmetb commented Aug 22, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, mgiessing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2022
@ahmetb ahmetb added the area/distribution Issues or PRs related to distribution and installation label Aug 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit f9772a9 into kubernetes-sigs:master Aug 22, 2022
@mkumatag
Copy link
Member

@ahmetb any idea when this will get into the release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/distribution Issues or PRs related to distribution and installation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants