fix version stamping in build script

[ahmetb]

Fixes #...
Related issue: #...

[ahmetb]

ARGH the unit test was taking dependency on broken behavior 🤦‍♂

@corneliusweig do you think I should remove GitTag and GitCommit from the test case doing the diff test? I think we can't find out those values during testing.

[ahmetb]

cc: @tony-yang it seems like we're doing cmp.Diff here which is map equality, though it would probably be better to just make sure if the specified set of keys/values exist in the output (instead of exact match)

[ahmetb]

/hold
until #497; then rebase.

[ahmetb]

/hold cancel

[corneliusweig]

Thanks for finding this bug.
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tony-yang]

cc: @tony-yang it seems like we're doing cmp.Diff here which is map equality, though it would probably be better to just make sure if the specified set of keys/values exist in the output (instead of exact match)

Fair point. Thanks Ahmet.