make TestKrewVersion a substring check #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of full map comparison, relax it to be "map has all these keys with the values that contain these strings". This way, we can test krew version stamping (as it's not deterministic at testing-time) as well as add more 'krew version' values without needing to strictly match test. Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
k8s-ci-robot
added
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## master #497 +/- ##
=====================================
Coverage 57% 57%
=====================================
Files 21 21
Lines 956 956
=====================================
Hits 545 545
Misses 357 357
Partials 54 54Continue to review full report at Codecov.
|
|
Yeah, I think the substring checking is good enough here. Thanks! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of full map comparison, relax it to be "map has all these keys with
the values that contain these strings".
This way, we can test krew version stamping (as it's not deterministic at
testing-time) as well as add more 'krew version' values without needing to
strictly match test.
Related issue: #496