-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs update - developer guide #690
Docs update - developer guide #690
Conversation
@@ -95,8 +95,8 @@ accessible to download from user’s machine. The relevant fields are: | |||
## Specifying platform-specific instructions | |||
|
|||
Krew makes it possible to install the same plugin on different operating systems | |||
(like `windows`, `darwin` (macOS), and `linux`) and different architectures | |||
(like `amd64`, `386`, `arm`). | |||
(e.g., Windows, macOS, and Linux) and different architectures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might need to restore this line as the code
strings need to be preserved verbatim.
(like `windows`, `darwin` (macOS), and `linux`) and different architectures | ||
(like `amd64`, `386`, `arm`). | ||
(e.g., Windows, macOS, and Linux) and different architectures | ||
(e.g., `amd64`, `386`, and `arm`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we also add arm64
here
2. Click the “Individual Plugin Stats” reporting | ||
3. Choose your plugin from dropdown and browse the data for your plugin. | ||
1. Visit the [stats.krew.dev] dashboard. | ||
2. Click “Individual Plugin Stats”. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's append report
here. (click to the ... report)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks for the work!
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, chriskim06 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Here's most of the changes for the developer guide. I had a few questions on the doc but I figured I'd submit this portion for now (this is the large majority of the changes anyways).