Docs update - developer guide #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
ahmetb
reviewed
Feb 15, 2021
| @@ -95,8 +95,8 @@ accessible to download from user’s machine. The relevant fields are: | |||
| ## Specifying platform-specific instructions | |||
|
|
|||
| Krew makes it possible to install the same plugin on different operating systems | |||
| (like `windows`, `darwin` (macOS), and `linux`) and different architectures | |||
| (like `amd64`, `386`, `arm`). | |||
| (e.g., Windows, macOS, and Linux) and different architectures | |||
There was a problem hiding this comment.
we might need to restore this line as the code strings need to be preserved verbatim.
ahmetb
reviewed
Feb 15, 2021
| (like `windows`, `darwin` (macOS), and `linux`) and different architectures | ||
| (like `amd64`, `386`, `arm`). | ||
| (e.g., Windows, macOS, and Linux) and different architectures | ||
| (e.g., `amd64`, `386`, and `arm`). |
ahmetb
reviewed
Feb 15, 2021
| 2. Click the “Individual Plugin Stats” reporting | ||
| 3. Choose your plugin from dropdown and browse the data for your plugin. | ||
| 1. Visit the [stats.krew.dev] dashboard. | ||
| 2. Click “Individual Plugin Stats”. |
There was a problem hiding this comment.
let's append report here. (click to the ... report)
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, chriskim06 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's most of the changes for the developer guide. I had a few questions on the doc but I figured I'd submit this portion for now (this is the large majority of the changes anyways).