Docs follow up #701
Docs follow up #701
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
| @@ -95,8 +95,8 @@ accessible to download from a user’s machine. The relevant fields are: | |||
| ## Specifying platform-specific instructions | |||
|
|
|||
| Krew makes it possible to install the same plugin on different operating systems | |||
| (e.g., Windows, macOS, and Linux) and different architectures | |||
| (e.g., `amd64`, `386`, and `arm`). | |||
| (e.g., `windows`, `darwin` (macOS), and `linux`) and different architectures | |||
There was a problem hiding this comment.
| (e.g., `windows`, `darwin` (macOS), and `linux`) and different architectures | |
| (e.g., `windows`, `darwin`/macOS, and `linux`) and different architectures |
Nested parentheses in text look wonky.
There was a problem hiding this comment.
hmm I agree, I think the suggestion also looks a little wonky as well though. this is how it was before though with the nested parentheses. @ahmetb @corneliusweig do either of you have a preference?
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chriskim06, corneliusweig The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I'm going to leave it as is for now, especially since this is how it was before. /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Here are the rest of the changes. There were a couple things I missed in my previous PRs and a couple changes based on the review in #690