-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Go to 1.17 #744
Bump Go to 1.17 #744
Conversation
Welcome @gliptak! |
This change will only run our test suite with the 1.17 Go release. Do you also want to switch the project to go 1.17 (by modifying |
@corneliusweig updated |
I think maybe you want to change
to just
or maybe update how the test that's failing works. i haven't really looked into that yet |
Signed-off-by: Gábor Lipták <gliptak@gmail.com>
@chriskim06 updated |
/retest |
guessing that command doesn't work here, I'm going to manually rerun these checks |
I have re-triggered Netlify builds manually but if it continues to fail, feel free to merge manually. Idk what causes it to fail like this. |
Let's merge and see how Netlify takes it. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, gliptak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Gábor Lipták gliptak@gmail.com
Fixes #...
Related issue: #...