Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A modernization pass #756

Merged
merged 4 commits into from
Feb 24, 2022
Merged

Conversation

ferhatelmas
Copy link
Contributor

Related to #744, modernize with go 1.17

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 22, 2022
@ahmetb
Copy link
Member

ahmetb commented Feb 23, 2022

/approve

but the changes are failing netlify, with error:

9:38:45 AM: ────────────────────────────────────────────────────────────────
9:38:45 AM:   1. build.command from netlify.toml                            
9:38:45 AM: ────────────────────────────────────────────────────────────────
9:38:45 AM: ​
9:38:45 AM: $ hugo --buildFuture -b $DEPLOY_PRIME_URL && cd ./functions &&  go build -o api ./server
9:38:45 AM: Building sites …
9:38:45 AM:                    | EN
9:38:45 AM: -------------------+-----
9:38:45 AM:   Pages            | 40
9:38:45 AM:   Paginator pages  |  0
9:38:45 AM:   Non-page files   |  0
9:38:45 AM:   Static files     |  3
9:38:45 AM:   Processed images |  0
9:38:45 AM:   Aliases          |  0
9:38:45 AM:   Sitemaps         |  1
9:38:45 AM:   Cleaned          |  0
9:38:45 AM: Total in 88 ms
9:38:46 AM: # sigs.k8s.io/krew/site/functions/server
9:38:46 AM: server/main.go:225:12: undefined: io.ReadAll
9:38:46 AM: note: module requires Go 1.15
9:38:46 AM: ​
9:38:46 AM: ────────────────────────────────────────────────────────────────
9:38:46 AM:   "build.command" failed                                        
9:38:46 AM: ────────────────────────────────────────────────────────────────

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, ferhatelmas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2022
@ferhatelmas
Copy link
Contributor Author

@ahmetb PTAL

@ahmetb
Copy link
Member

ahmetb commented Feb 24, 2022

/lgtm
thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit fd53697 into kubernetes-sigs:master Feb 24, 2022
@ferhatelmas ferhatelmas deleted the modern branch February 25, 2022 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants