Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to go.mod #59

Closed
wants to merge 3 commits into from
Closed

Switch to go.mod #59

wants to merge 3 commits into from

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Mar 12, 2020

We import sigs.k8s.io/structured-merge-diff via versioned imports. This breaks the use of dep. We need this now.

Replaces #47

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 12, 2020
@stlaz
Copy link

stlaz commented Mar 12, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

@stlaz: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sanchezl
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@sanchezl: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@caesarxuchao
Copy link
Member

/approve

@caesarxuchao
Copy link
Member

/retest
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 12, 2020
@k8s-ci-robot
Copy link
Contributor

@sttts: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kube-storage-version-migrator-manually-launched-e2e 6f56a54 link /test pull-kube-storage-version-migrator-manually-launched-e2e
pull-kube-storage-version-migrator-fully-automated-e2e 6f56a54 link /test pull-kube-storage-version-migrator-fully-automated-e2e
pull-kube-storage-version-migrator-disruptive 6f56a54 link /test pull-kube-storage-version-migrator-disruptive

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 20, 2020
@k8s-ci-robot
Copy link
Contributor

@sttts: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sanchezl
Copy link
Contributor

Fixed by #47

@caesarxuchao
Copy link
Member

Fixed by #47. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@caesarxuchao caesarxuchao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sttts @stlaz @k8s-ci-robot @sanchezl @caesarxuchao