move to go.mod #47

sanchezl · 2019-11-04T21:14:15Z

go mod init
go mod vendor

k8s-ci-robot · 2019-11-04T21:14:23Z

Hi @sanchezl. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

caesarxuchao · 2019-11-04T21:23:30Z

Why are there changes in the vendor/ folder? I expect with #41 already merged, this PR will not change the vendor/ folder.

sanchezl · 2019-11-05T04:59:52Z

Why are there changes in the vendor/ folder? I expect with #41 already merged, this PR will not change the vendor/ folder.

go mod vendor has different algorithms for deciding what to actually vendor (copies source in packages, not entire modules) and 2) might resolve dependencies differently (but I pinned the dependencies explicitly pinned before).

deads2k · 2019-11-06T19:37:01Z

/ok-to-test

caesarxuchao · 2019-11-06T23:14:11Z

go.mod

+	k8s.io/kube-aggregator v0.0.0-kubernetes-1.16.2
+)
+
+replace (


Is the "replace" section manually edited? Why are the specific revisions used here, instead of v0.0.0-kubernetes-1.16.2?

Yes, the replace section is manually edited.

go.mod does not allow you to specify a branch or non-semver tag. If you are not using a semver tag (e.g. v1.0.0), which kubernetes does not at the moment, you must use a revision, and that is converted to a pseudo-version. Unfortunately, when you run certain go commands (such as go build), there is a chance that the pseudo version will be replaced with the latest from master. So...

I set the k8s.io/* dependencies to a pseudo version of v0.0.0-kubernetes-1.16.2. The format accomplishes two things: 1. go sees it as a pseudo-version and 2. the kubernetes-1.16.2 part is a reminder of what I really want to require.

Adding replace entries for k8s.io/* entries accomplishes the following: 1. the psedu-version in the require section is ignored, and 2. The revision of the k8s.io/* module is effectively pinned and won't change unless explicitly updated.

Thanks for the explanation.

If making "v0.0.0-kubernetes-1.16.2" a pseudo version isn't a common practice, can you document the purpose in comments?

In the future, when we need to bump the version of k8s.io/*, I think we need to manually edit the "require" section and the "replace" section, right?

Unfortunately, when you run certain go commands (such as go build), there is a chance that the pseudo version will be replaced with the latest from master

Can you say what commands exactly?
Anyhow, if we just use the revision based pseudo-version generated by go, it's not obvious what tag the revision matches to.

Let's do the 1.17 port soon. It has proper semver tags.

caesarxuchao · 2019-11-06T23:19:25Z

go.mod

@@ -0,0 +1,34 @@
+module github.com/kubernetes-sigs/kube-storage-version-migrator


switch to "sig.k8s.io"?

I will do that in a separate PR.

@sanchezl it's a small thing and it's been two months.

@sanchezl it's a small thing and it's been two months.

there's a PR open #46 .

sanchezl · 2019-12-20T18:29:23Z

/test pull-kube-storage-version-migrator-disruptive

sanchezl · 2020-01-10T21:33:15Z

/retest

caesarxuchao · 2020-01-10T23:34:11Z

/retest

sanchezl · 2020-01-22T03:02:10Z

/test pull-kube-storage-version-migrator-disruptive

sanchezl · 2020-01-29T19:20:51Z

/test pull-kube-storage-version-migrator-disruptive

caesarxuchao · 2020-01-29T19:29:04Z

when listing resources, if a Not Found (404) error happens here (e.g. bad gvr), migrator will loop here forever (I added an IsNotFound check here to fail the migration).

@sanchezl thanks for the investigation. Can you say more about this bug? Is it stuck at this line? Is the storage migrator handling a k8s native resource or a CRD?

sanchezl · 2020-01-29T20:07:29Z

when listing resources, if a Not Found (404) error happens here (e.g. bad gvr), migrator will loop here forever (I added an IsNotFound check here to fail the migration).

@sanchezl thanks for the investigation. Can you say more about this bug? Is it stuck at this line? Is the storage migrator handling a k8s native resource or a CRD?

This particular bug does not happen in any of the tests in this repo. I found it when testing on my own clusters and accidentally providing invalid GVRs.

sanchezl · 2020-02-17T17:25:03Z

/retest

sanchezl · 2020-02-17T19:33:54Z

/retest

sanchezl · 2020-02-17T20:45:21Z

@caesarxuchao , @deads2k PTAL, I've finally gotten the tests to run consistently.
https://prow.k8s.io/pr-history/?org=kubernetes-sigs&repo=kube-storage-version-migrator&pr=47

sanchezl · 2020-02-17T20:46:59Z

/retest

deads2k · 2020-02-18T15:02:49Z

pkg/controller/kubemigrator.go

 	metrics.Metrics.ObserveFailedMigration(resource(m).String())
-	return err
+	klog.Errorf("%v: migration failed: %v", m.Name, err)
+	return updateErr


thi sis a change in behavior. Why shouldn't we return the failure when we failed. This allows us to return nil after having an error. If this is correct, add comment explaining why.

Did not intend to change behavior. Any recommendations for handling the updateErr ?
Please comment at #58 instead.

sttts · 2020-03-12T09:44:09Z

We import sigs.k8s.io/structured-merge-diff via versioned imports. This breaks the use of dep. We need this now.

caesarxuchao · 2020-03-20T16:33:22Z

/lgtm
/approve

k8s-ci-robot · 2020-03-20T16:33:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, deads2k, sanchezl, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [caesarxuchao,deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 4, 2019

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 4, 2019

k8s-ci-robot requested review from caesarxuchao and deads2k November 4, 2019 21:14

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 4, 2019

sanchezl force-pushed the sigs-go.mod branch from 0656152 to cbf34b9 Compare November 5, 2019 05:00

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 6, 2019

caesarxuchao reviewed Nov 6, 2019

View reviewed changes

sanchezl force-pushed the sigs-go.mod branch from cbf34b9 to 3bfeaef Compare December 16, 2019 19:45

sanchezl force-pushed the sigs-go.mod branch 5 times, most recently from 1063503 to 42d6edb Compare December 21, 2019 05:50

sanchezl force-pushed the sigs-go.mod branch 3 times, most recently from 3956ca8 to c3307cd Compare January 10, 2020 21:27

sanchezl force-pushed the sigs-go.mod branch 3 times, most recently from ae4e310 to 657a724 Compare January 21, 2020 19:43

sanchezl force-pushed the sigs-go.mod branch from b3cc268 to b591ce1 Compare January 29, 2020 16:17

sanchezl force-pushed the sigs-go.mod branch 5 times, most recently from d031dbe to 1abfac2 Compare February 4, 2020 16:16

sanchezl force-pushed the sigs-go.mod branch from 77bd1ac to 7b62c96 Compare February 17, 2020 16:02

deads2k reviewed Feb 18, 2020

View reviewed changes

sanchezl force-pushed the sigs-go.mod branch from d7f59b4 to 3519eed Compare February 18, 2020 17:14

sttts mentioned this pull request Mar 12, 2020

Switch to go.mod #59

Closed

sanchezl force-pushed the sigs-go.mod branch from 3519eed to 6bb035a Compare March 17, 2020 18:57

sanchezl mentioned this pull request Mar 19, 2020

REQUEST: New membership for sanchezl kubernetes/org#1730

Closed

6 tasks

sanchezl added 3 commits March 19, 2020 20:59

go mod init

88dedcd

go mod vendor

c54c1ee

force use of vendor

1e59448

sanchezl force-pushed the sigs-go.mod branch from 4d8410a to 1e59448 Compare March 20, 2020 01:00

k8s-ci-robot assigned caesarxuchao Mar 20, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2020

k8s-ci-robot merged commit 626ae2e into kubernetes-sigs:master Mar 20, 2020

alebedev87 mentioned this pull request Mar 30, 2023

OCPBUGS-8646: bump openshift/library-go to drop mongo-driver references openshift/router#462

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move to go.mod #47

move to go.mod #47

sanchezl commented Nov 4, 2019 •

edited

Loading

k8s-ci-robot commented Nov 4, 2019

caesarxuchao commented Nov 4, 2019

sanchezl commented Nov 5, 2019

deads2k commented Nov 6, 2019

caesarxuchao Nov 6, 2019

sanchezl Nov 7, 2019

caesarxuchao Nov 8, 2019

sttts Jan 22, 2020

caesarxuchao Nov 6, 2019

sanchezl Nov 7, 2019

deads2k Jan 24, 2020

deads2k Jan 24, 2020

sanchezl commented Dec 20, 2019

sanchezl commented Jan 10, 2020

caesarxuchao commented Jan 10, 2020

sanchezl commented Jan 22, 2020

sanchezl commented Jan 29, 2020

caesarxuchao commented Jan 29, 2020

sanchezl commented Jan 29, 2020

sanchezl commented Feb 17, 2020

sanchezl commented Feb 17, 2020

sanchezl commented Feb 17, 2020 •

edited

Loading

sanchezl commented Feb 17, 2020

deads2k Feb 18, 2020

sanchezl Feb 26, 2020

sttts commented Mar 12, 2020

caesarxuchao commented Mar 20, 2020

k8s-ci-robot commented Mar 20, 2020

		@@ -0,0 +1,34 @@
		module github.com/kubernetes-sigs/kube-storage-version-migrator

move to go.mod #47

move to go.mod #47

Conversation

sanchezl commented Nov 4, 2019 • edited Loading

k8s-ci-robot commented Nov 4, 2019

caesarxuchao commented Nov 4, 2019

sanchezl commented Nov 5, 2019

deads2k commented Nov 6, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sanchezl commented Dec 20, 2019

sanchezl commented Jan 10, 2020

caesarxuchao commented Jan 10, 2020

sanchezl commented Jan 22, 2020

sanchezl commented Jan 29, 2020

caesarxuchao commented Jan 29, 2020

sanchezl commented Jan 29, 2020

sanchezl commented Feb 17, 2020

sanchezl commented Feb 17, 2020

sanchezl commented Feb 17, 2020 • edited Loading

sanchezl commented Feb 17, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sttts commented Mar 12, 2020

caesarxuchao commented Mar 20, 2020

k8s-ci-robot commented Mar 20, 2020

sanchezl commented Nov 4, 2019 •

edited

Loading

sanchezl commented Feb 17, 2020 •

edited

Loading