Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hack/update-codegen.sh: add -mod=vendor to work with recent Golang #93

Merged
merged 4 commits into from
Apr 21, 2021
Merged

hack/update-codegen.sh: add -mod=vendor to work with recent Golang #93

merged 4 commits into from
Apr 21, 2021

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Apr 19, 2021

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 19, 2021
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 19, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 19, 2021
@sttts
Copy link
Contributor Author

sttts commented Apr 19, 2021

/assign @deads2k

@sttts
Copy link
Contributor Author

sttts commented Apr 20, 2021

/retest

deads2k
deads2k reviewed Apr 21, 2021
View reviewed changes
hack/update-codegen.sh
schemapatch:manifests="${THIS_REPO_ABSOLUTE}/manifests" \
paths="${THIS_REPO_ABSOLUTE}/pkg/apis/migration/v1alpha1" \
output:dir="${THIS_REPO_ABSOLUTE}/manifests"

go run ./vendor/k8s.io/code-generator/cmd/client-gen \
curl -s -f -L https://github.com/krishicks/yaml-patch/releases/download/v0.0.10/yaml_patch_$(go env GOHOSTOS) -o _output/yaml-patch
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment about what this is doing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

deads2k
deads2k reviewed Apr 21, 2021
View reviewed changes
manifests/storage_state_crd.yaml-patch
@@ -0,0 +1,6 @@
- op: add
path: /spec/versions/name=v1alpha1/schema/openAPIV3Schema/properties/metadata/properties
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

readd the metadata.name schema. It looks like it was just manually added to the CRD manifest and controller-tools will override that.

@k8s-ci-robot
Copy link
Contributor

@sttts: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kube-storage-version-migrator-ha-master a8e94f9 link /test pull-kube-storage-version-migrator-ha-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

sttts
sttts commented Apr 21, 2021
View reviewed changes
pkg/apis/migration/v1alpha1/types.go
@@ -120,7 +120,6 @@ type StorageVersionMigrationList struct {
// The state of the storage of a specific resource.
type StorageState struct {
metav1.TypeMeta `json:",inline"`
// The name must be "<.spec.resource.resouce>.<.spec.resource.group>".
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deads2k this was wrong. You cannot add a custom comment to metadata.

@deads2k
Copy link

deads2k commented Apr 21, 2021

the more you know...

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2021
@k8s-ci-robot k8s-ci-robot merged commit acdee30 into kubernetes-sigs:master Apr 21, 2021
@sttts sttts mentioned this pull request May 3, 2021
Merged
@roycaihw roycaihw mentioned this pull request Sep 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sttts @k8s-ci-robot @deads2k