-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hack/update-codegen.sh: add -mod=vendor to work with recent Golang #93
Changes from all commits
5f282e0
cc3f072
7d4e109
a8e94f9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
_output |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
- op: add | ||
path: /spec/versions/name=v1alpha1/schema/openAPIV3Schema/properties/metadata/properties | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what does this do? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. readd the metadata.name schema. It looks like it was just manually added to the CRD manifest and controller-tools will override that. |
||
value: | ||
name: | ||
description: name must be "<.spec.resource.resouce>.<.spec.resource.group>". | ||
type: string |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -120,7 +120,6 @@ type StorageVersionMigrationList struct { | |
// The state of the storage of a specific resource. | ||
type StorageState struct { | ||
metav1.TypeMeta `json:",inline"` | ||
// The name must be "<.spec.resource.resouce>.<.spec.resource.group>". | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @deads2k this was wrong. You cannot add a custom comment to metadata. |
||
// +optional | ||
metav1.ObjectMeta `json:"metadata,omitempty"` | ||
// Specification of the storage state. | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment about what this is doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done