Skip to content

Commit

Permalink
Merge pull request #341 from yuwenma/bump-ci-go
Browse files Browse the repository at this point in the history
fix: bump ci go to v1.20 and fix goimports
  • Loading branch information
k8s-ci-robot committed Jun 23, 2023
2 parents 9a41055 + 28ab6e9 commit f580648
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: Set up go
uses: actions/setup-go@v2
with:
go-version: 1.19
go-version: '1.20'
stable: true

- run: |
Expand All @@ -39,7 +39,7 @@ jobs:
- name: Set up go
uses: actions/setup-go@v2
with:
go-version: 1.19
go-version: '1.20'
stable: true

- run: |
Expand All @@ -64,7 +64,7 @@ jobs:
- uses: actions/checkout@v1
- uses: actions/setup-go@v1
with:
go-version: 1.19
go-version: '1.20'
- name: Install latest version of Kind
run: |
GO111MODULE=on go get sigs.k8s.io/kind
Expand Down
3 changes: 2 additions & 1 deletion pkg/patterns/declarative/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -605,4 +605,5 @@ func (rt recordTrigger) Delete(ctx context.Context, ev event.DeleteEvent, _ work
}
}

func (rt recordTrigger) Generic(ctx context.Context, ev event.GenericEvent, _ workqueue.RateLimitingInterface) {}
func (rt recordTrigger) Generic(ctx context.Context, ev event.GenericEvent, _ workqueue.RateLimitingInterface) {
}
1 change: 0 additions & 1 deletion pkg/test/testreconciler/simpletest/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ func (r *SimpleTestReconciler) SetupWithManager(mgr ctrl.Manager) error {
if err != nil {
return err
}


// Watch for changes to SimpleTest objects
err = c.Watch(source.Kind(mgr.GetCache(), &api.SimpleTest{}), &handler.EnqueueRequestForObject{})
Expand Down

0 comments on commit f580648

Please sign in to comment.