Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bump ci go to v1.20 and fix goimports #341

Merged
merged 1 commit into from
Jun 23, 2023
Merged

fix: bump ci go to v1.20 and fix goimports #341

merged 1 commit into from
Jun 23, 2023

Conversation

yuwenma
Copy link
Contributor

@yuwenma yuwenma commented Jun 23, 2023 •
edited

What this PR does / why we need it:
This PR fixes the CI "verify-goimports" and "verify-gomod" which the CI go 1.19 cannot run go mod tidy for k-d-p go 1.20 modules. This currently blocks any upcoming PRs to pass the CI check.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 23, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 23, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 23, 2023
@yuwenma yuwenma changed the title fix: bump ci go to v1.20 fix: bump ci go to v1.20 and fix goimports Jun 23, 2023
@yuwenma
Copy link
Contributor Author

yuwenma commented Jun 23, 2023

/assign @justinsb

@justinsb
Copy link
Contributor

Thanks for fixing!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit f580648 into kubernetes-sigs:master Jun 23, 2023
3 checks passed
@atoato88
Copy link
Contributor

atoato88 commented Jun 26, 2023 •
edited

I created almost same things about this PR's topic by #339
This PR is already merged I will close the #339.
It's good to be merged quickly 👍

@atoato88 atoato88 mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsonj johnsonj Awaiting requested review from johnsonj

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yuwenma @justinsb @k8s-ci-robot @atoato88