Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix github workflows #339

Closed
wants to merge 1 commit into from
Closed

Fix github workflows #339

wants to merge 1 commit into from

Conversation

atoato88
Copy link
Contributor

What this PR does / why we need it:

This PR fixes the problem with github workflows, and update go-version with 1.20 on workflows.

Which issue(s) this PR fixes:
NONE

Special notes for your reviewer:
NONE

Additional documentation:
NONE

@atoato88
Fix github workflows
935a30a 
This PR fixes the problem with github workflows, and update go-version
with 1.20 on workflows.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atoato88

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 20, 2023
@atoato88
Copy link
Contributor Author

Following is the sample error on github before merging this PR:
https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/actions/runs/5171521822

By this PR, github workflow error will be fixed:
https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/actions/runs/5318352072

@atoato88
Copy link
Contributor Author

/assign @justinsb
Could you review this?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 24, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@atoato88 atoato88 mentioned this pull request Jun 26, 2023
Merged
@atoato88
Copy link
Contributor Author

/close

This problem is fixed by #341, so I close this PR.
Thank you for @yuwenma 👍

@k8s-ci-robot
Copy link
Contributor

@atoato88: Closed this PR.

In response to this:

/close

This problem is fixed by #341, so I close this PR.
Thank you for @yuwenma 👍

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsonj johnsonj Awaiting requested review from johnsonj

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@justinsb justinsb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atoato88 @k8s-ci-robot @justinsb