Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: bump to controller-runtime v0.7.0-alpha.5 #127

Merged
merged 1 commit into from
Nov 9, 2020
Merged

deps: bump to controller-runtime v0.7.0-alpha.5 #127

merged 1 commit into from
Nov 9, 2020

Conversation

estroz
Copy link
Contributor

@estroz estroz commented Oct 27, 2020 •
edited

  • go.mod,go.sum: bump k8s deps to v0.19.2, controller-runtime to v0.7.0-alpha.5
  • pkg: use client.Object instead of runtime.Object and add context.Context to relevant methods

Once v0.7.0 is released we'll need to bump again, but it should be much simpler then.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Oct 27, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 27, 2020
@estroz
Copy link
Contributor Author

estroz commented Oct 27, 2020

/assign @justinsb
/cc @DirectXMan12

@estroz estroz mentioned this pull request Oct 27, 2020
Closed
3 tasks
camilamacedo86
camilamacedo86 reviewed Oct 27, 2020
View reviewed changes
go.mod Outdated
sigs.k8s.io/cli-utils v0.16.0
sigs.k8s.io/controller-runtime v0.6.0
sigs.k8s.io/controller-runtime v0.7.0-alpha.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@estroz IMO we need wait for the stable release to be able to bump the dep.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a good reason to wait? I don't expect any changes to go in aside from bugfixes at this point, although it is technically an alpha release. Unless there is a plan to release this project soon, bumping to alpha now then bumping to stable before a release makes sense to me since the alpha bump will only ever be on master. This also helps test out the controller-runtime v0.7.0 release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed that. I think it is fine we move forward.
Really thank you for your collab.

@estroz
deps: bump to controller-runtime v0.7.0-alpha.5
730cbae 
pkg: use client.Object instead of runtime.Object and add context.Context
to relevant methods
@estroz estroz changed the title deps: bump to controller-runtime v0.7.0-alpha.4 deps: bump to controller-runtime v0.7.0-alpha.5 Nov 3, 2020
camilamacedo86
camilamacedo86 approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2020
@camilamacedo86 camilamacedo86 mentioned this pull request Nov 5, 2020
Merged
@estroz
Copy link
Contributor Author

estroz commented Nov 5, 2020

ping @justinsb

@christopherhein christopherhein mentioned this pull request Nov 8, 2020
Merged
@estroz estroz mentioned this pull request Nov 8, 2020
Merged
@estroz
Copy link
Contributor Author

estroz commented Nov 8, 2020

@pwittrock can you take a look at this

@pwittrock
Copy link

/approve

@christopherhein
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, estroz, pwittrock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2020
@pwittrock
Copy link

@estroz ping me on slack for reviews -- I get too many GH notifications for this to break through the noise

@k8s-ci-robot k8s-ci-robot merged commit 1cbf859 into kubernetes-sigs:master Nov 9, 2020
@estroz estroz deleted the deps/c-r-v0.7.0 branch November 9, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@atoato88 atoato88 Awaiting requested review from atoato88

@monopole monopole Awaiting requested review from monopole

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

Assignees

@justinsb justinsb

@christopherhein christopherhein

@camilamacedo86 camilamacedo86

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@estroz @pwittrock @christopherhein @k8s-ci-robot @camilamacedo86 @justinsb