-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: bump to controller-runtime v0.7.0-alpha.5 #127
Conversation
/assign @justinsb |
go.mod
Outdated
sigs.k8s.io/cli-utils v0.16.0 | ||
sigs.k8s.io/controller-runtime v0.6.0 | ||
sigs.k8s.io/controller-runtime v0.7.0-alpha.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@estroz IMO we need wait for the stable release to be able to bump the dep.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a good reason to wait? I don't expect any changes to go in aside from bugfixes at this point, although it is technically an alpha release. Unless there is a plan to release this project soon, bumping to alpha now then bumping to stable before a release makes sense to me since the alpha bump will only ever be on master. This also helps test out the controller-runtime v0.7.0 release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed that. I think it is fine we move forward.
Really thank you for your collab.
pkg: use client.Object instead of runtime.Object and add context.Context to relevant methods
861d38a
to
730cbae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
ping @justinsb |
@pwittrock can you take a look at this |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, estroz, pwittrock The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@estroz ping me on slack for reviews -- I get too many GH notifications for this to break through the noise |
Once v0.7.0 is released we'll need to bump again, but it should be much simpler then.